New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore time difference order so future extrapolation exceptions show positive seconds into future #522

Merged

tfoote merged 1 commit into ros:noetic-devel from lucasw:restore_tdiff

Feb 4, 2022

Contributor

lucasw commented Nov 3, 2021

There was a manual merge 52bff88 as a part of #470 that caused this regression, resulting in negative seconds into the future:

tf2.ExtrapolationException: Lookup would require extrapolation -0.041266203s into the future.

If the t0 - t1 ordering is confusing could alternatively do -tdiff.to_sec().


          Restore time difference order so future extrapolation exceptions don'…

c5f5bf7

…t show non-sensical negative seconds into the future

lucasw requested a review from tfoote as a code owner

November 3, 2021 14:36

tfoote approved these changes

View reviewed changes

Member

tfoote left a comment

Yeah, this is the correct behavior.

tfoote merged commit c0cb44e into ros:noetic-devel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet